added .npmignore file #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including the test/ folder to .npmignore means it will not be downloaded on npm install. This has two advantages: 1. less data to download on `npm install` 2. when developing a google chrome extension, a warning pops out, saying *This extension includes the key file '.../node-rsa/test/private_pkcs1.pem'. You probably don't want to do that.* There is no security threat since the key is not used anyway; the npmignore just gets rid of the warning.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including the
test/folder to.npmignoremeans it will not be downloaded onnpm install. This has two advantages:npm installMore info about .npmignore: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package
Has been done in thom4parisot/crx#47